Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repr to format s3 exceptions #6104

Closed
wants to merge 1 commit into from
Closed

Use repr to format s3 exceptions #6104

wants to merge 1 commit into from

Conversation

vin01
Copy link

@vin01 vin01 commented Apr 19, 2021

Use of repr would ensure that exceptions without any error message (like MemoryError) are displayed properly to support debugging.

I recently debugged a MemoryError where error message would just say:

download failed: s3://remote to local-path

Having exception information in the log would be very helpful, it is not even displayed in the DEBUG logs currently.

I am not sure if using repr is the best approach here though, wdyt?

Use of repr would ensure that exceptions without any error message (like MemoryError) are displayed properly to support debugging
@stealthycoin
Copy link
Contributor

This needs an issue outlining the problem, if it gets sufficient traction we could move forward to the implementation phase.
#6828 details our new contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants