Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add profile and role sorting to sso configure #6205

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

ryansonshine
Copy link
Contributor

Issue #, if available:
Closes #6108

Description of changes:
This change adds sorting to profiles and roles when running aws sso configure listing them in ascending alphabetical order by default (case insensitive).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This change adds sorting to profiles and roles when running
`aws sso configure` listing them in ascending alphabetical
order by default (case insensitive).
@ryansonshine ryansonshine changed the title Add profile and role sorting to sso configure Add profile and role sorting to sso configure Jun 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #6205 (66a7bac) into v2 (da94e8c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6205      +/-   ##
==========================================
- Coverage   94.18%   94.11%   -0.07%     
==========================================
  Files         273      273              
  Lines       21678    21680       +2     
==========================================
- Hits        20417    20405      -12     
- Misses       1261     1275      +14     
Impacted Files Coverage Δ
awscli/customizations/configure/sso.py 100.00% <100.00%> (ø)
awscli/compat.py 60.81% <0.00%> (-2.45%) ⬇️
awscli/testutils.py 65.71% <0.00%> (-0.89%) ⬇️
awscli/table.py 95.07% <0.00%> (-0.76%) ⬇️
awscli/help.py 96.48% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da94e8c...66a7bac. Read the comment docs.

@ryansonshine ryansonshine changed the title Add profile and role sorting to sso configure [v2] Add profile and role sorting to sso configure Jun 3, 2021
@kdaily kdaily added the pr:needs-review This PR needs a review from a Member. label Jun 10, 2021
@kdaily kdaily linked an issue Jun 10, 2021 that may be closed by this pull request
@kdaily kdaily added the customization Issues related to CLI customizations (located in /awscli/customizations) label Jun 10, 2021
@kdaily kdaily added feature-request A feature should be added or improved. and removed feature-request A feature should be added or improved. labels Aug 11, 2021
@rayjanwilson
Copy link

@kdaily looking for any updates on when this will be merged

@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Oct 29, 2021
@simonweil
Copy link

Please merge this, it's soooo frustrating to look for the specific account when there are tens of them me the order changes every time...

@ryansonshine
Copy link
Contributor Author

Please merge this, it's soooo frustrating to look for the specific account when there are tens of them me the order changes every time...

@kdaily is there a specific team that needs to review this? If so, can we ping them and get an update?

Issue #6108 has 35 👍's and this PR hasn't seen an update for over 5 months, it's a bit discouraging for contributors to put in the time and effort to voluntarily implement functionality only for it to go ignored.

@ryansonshine
Copy link
Contributor Author

@joguSD , is this something you're able to review?

@simonweil
Copy link

Any chance this feature graduates? It would be so helpful for my day to day as a heavy AWS user...

@stealthycoin stealthycoin removed pr:needs-review This PR needs a review from a Member. needs-review This issue or pull request needs review from a core team member. labels Apr 5, 2022
@stealthycoin
Copy link
Contributor

Hi @ryansonshine thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have determined this PR to be in the Implementation stage (described here).

We are tracking this PR here on our project board and it can be set to to the review stage once new changes are ready to be reviewed. This will happen once we get through most of the open PRs and sort the open PRs against the criteria in our new contribution guide.

@gmembre-zenika
Copy link

Hi @stealthycoin,

any updates on this PR please ?

Thx

@SebastienFourreau
Copy link

Hello @stealthycoin

🆙 please

Thanks a lot !

@SebastienFourreau
Copy link

Hi again !

Can someone do the necessary to review and merge this Pull Request please ?
@stealthycoin / @kdaily

Thanks

@coliss86
Copy link

Hello,

this PR is opened since 2 years and no updates :-(
What is wrong with it ? What can be done to merge it please ?
@nateprewitt please ;-)

Regards

@lteixeira-dock
Copy link

Any updates on this PR, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community customization Issues related to CLI customizations (located in /awscli/customizations) ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort accounts in aws configure sso
10 participants