Changed the cutoff to 2/3 instead of 0.8 #6249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
added
the
needs-review
|
Hi @YoniMelki thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. In order to have a PR like this looked at and reviewed we need an issue to be created that details what the change is and why. Before it can be advanced to the pull request stage it needs to have at least 10 👍s. Until then I am closing this PR. Specifically for this PR, we would need a good reason to make this change since the impact is somewhat unknown. Examples of what the effects of this change are would help, and tests that demonstrate that nothing unexpected is also changing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I changed the cutoff of the
argparserto 2/3 instead of 0.8 in order to cover more services (e.g: ec2)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.