Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the cutoff to 2/3 instead of 0.8 #6249

Closed
wants to merge 1 commit into from
Closed

Changed the cutoff to 2/3 instead of 0.8 #6249

wants to merge 1 commit into from

Conversation

YoniMelki
Copy link

Description of changes:
I changed the cutoff of the argparser to 2/3 instead of 0.8 in order to cover more services (e.g: ec2)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Nov 6, 2021
@stealthycoin
Copy link
Contributor

Hi @YoniMelki thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process.

In order to have a PR like this looked at and reviewed we need an issue to be created that details what the change is and why. Before it can be advanced to the pull request stage it needs to have at least 10 👍s. Until then I am closing this PR.

Specifically for this PR, we would need a good reason to make this change since the impact is somewhat unknown. Examples of what the effects of this change are would help, and tests that demonstrate that nothing unexpected is also changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants