Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported PyYAML range. #6648

Closed
wants to merge 1 commit into from
Closed

Conversation

zozoens31
Copy link

Issue #, if available:

Description of changes:
Update supported PyYAML range to include 6.0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #6648 (ae78bf3) into develop (3ecbd27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6648   +/-   ##
========================================
  Coverage    92.84%   92.84%           
========================================
  Files          204      204           
  Lines        16293    16293           
========================================
  Hits         15128    15128           
  Misses        1165     1165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecbd27...ae78bf3. Read the comment docs.

@pcorpet
Copy link

pcorpet commented Mar 21, 2022

Any update on this PR? What is the next step to get it merged?

@stealthycoin stealthycoin added the needs-review This issue or pull request needs review from a core team member. label Apr 13, 2022
@kdaily kdaily added ready-for-review feature-request A feature should be added or improved. dependencies This issue is a problem in a dependency. community and removed needs-review This issue or pull request needs review from a core team member. labels Apr 13, 2022
@dhalenok
Copy link

Any updates? This is somewhat of a blocker when using alongside other dependencies which require PyYAML>=6.0.

@kdewald
Copy link

kdewald commented Jan 30, 2023

Hi, will this be resolved at some point? It seems like a trivial issue that will improve the user experience by a lot.

@dbuades
Copy link

dbuades commented Apr 7, 2023

Hello @stealthycoin, sorry for pinging you in this old PR, but you seem to be actively maintaining this repo.

I was wondering if there is an underlying issue blocking the merge of this PR? Or if maybe it just fell through the cracks?
If possible, it would be very useful to merge this PR since many libraries ask now for PyYAML>=6.0 and aws-cli impedes installing it.

Thank you very much in advance!

@phajduk
Copy link

phajduk commented Apr 20, 2023

@stealthycoin I think you should be aware that due to the fact that AWS released the newest Managed Airflow (v2.5.1) that is using PyYAML v6+ without merging this pull, AWS customers won't be able to install awscli in newest MWAA. awscli is required to handle communication between MWAA and EKS.

@TNonet TNonet mentioned this pull request May 19, 2023
2 tasks
@vlazuka
Copy link

vlazuka commented May 25, 2023

Pitching in, it's a dealbreaker for me to upgrade my team's Airflow instance. Doesn't seem to be a huge change for @aws-cli team to merge this pr

@shubham22
Copy link

AWS released the newest Managed Airflow (v2.5.1) that is using PyYAML v6+ without merging this pull, AWS customers won't be able to install awscli in newest MWAA

@phajduk - MWAA pre-installs aws cli v2, which doesn't have PyYAML as dependency. Were you trying to install cli v1 on MWAA? If yes, you should move over to pre-installed v2.

@vlazuka
Copy link

vlazuka commented Jun 29, 2023

@shubham22 but what about other platforms, not MWAA?

@shubham22
Copy link

@vlazuka - I was only answering w.r.t. MWAA. Based on the latest comment here from AWS cli member, it does seem like cli v2 is the only workaround right now.

@jonathan343
Copy link
Contributor

Resolved in #8037. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. ready-for-review
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

None yet