Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --no-browser flag on sso login commands #6743

Merged
merged 1 commit into from Mar 9, 2022

Conversation

joguSD
Copy link
Contributor

@joguSD joguSD commented Feb 24, 2022

Added support for the --no-browser flag on the aws confgure sso and aws sso login commands.

Closes #5301.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #6743 (3eec910) into v2 (2800376) will increase coverage by 0.02%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6743      +/-   ##
==========================================
+ Coverage   93.66%   93.69%   +0.02%     
==========================================
  Files         349      350       +1     
  Lines       35367    35689     +322     
  Branches     5053     5105      +52     
==========================================
+ Hits        33128    33440     +312     
- Misses       1643     1647       +4     
- Partials      596      602       +6     
Impacted Files Coverage Δ
awscli/customizations/sso/utils.py 90.38% <92.30%> (-0.10%) ⬇️
awscli/customizations/configure/sso.py 99.50% <100.00%> (+0.01%) ⬆️
awscli/customizations/sso/login.py 100.00% <100.00%> (ø)
awscli/botocore/crt/auth.py 84.15% <0.00%> (-0.53%) ⬇️
awscli/botocore/auth.py 94.66% <0.00%> (-0.40%) ⬇️
awscli/s3transfer/upload.py 94.77% <0.00%> (-0.29%) ⬇️
awscli/botocore/serialize.py 98.69% <0.00%> (-0.03%) ⬇️
awscli/s3transfer/manager.py 98.02% <0.00%> (ø)
awscli/s3transfer/constants.py 100.00% <0.00%> (ø)
awscli/botocore/httpchecksum.py 96.82% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2800376...3eec910. Read the comment docs.

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note, otherwise looks good.

awscli/customizations/sso/utils.py Outdated Show resolved Hide resolved
@joguSD joguSD requested a review from kyleknap February 28, 2022 17:23
Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just had some small feedback.

tests/functional/sso/test_login.py Outdated Show resolved Hide resolved
awscli/customizations/configure/sso.py Outdated Show resolved Hide resolved
awscli/customizations/sso/utils.py Outdated Show resolved Hide resolved
awscli/customizations/sso/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants