New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the --no-browser flag on sso login commands #6743
Conversation
Codecov Report
@@ Coverage Diff @@
## v2 #6743 +/- ##
==========================================
+ Coverage 93.66% 93.69% +0.02%
==========================================
Files 349 350 +1
Lines 35367 35689 +322
Branches 5053 5105 +52
==========================================
+ Hits 33128 33440 +312
- Misses 1643 1647 +4
- Partials 596 602 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just had some small feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚢
Added support for the
--no-browser
flag on theaws confgure sso
andaws sso
login commands.Closes #5301.