Add support for external-id in aws eks get-token
#6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting a review on this? @justindho perhaps? |
jbg
force-pushed
the
jbg/aws-eks-get-token-external-id
branch
from
c5a4a16
to
e0e696a
Compare
|
LGTM |
|
@kyleknap Could you please review this one? 🙇♂️ |
|
@yuxiang-zhang Do you have an example of a test? |
yeah inside tests/functional/eks/test_get_token.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5942
Description of changes: Add an optional
--external-idparameter toaws eks get-tokenand pass it toAssumeRole.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.