Add waiter config override option for cloudformation deploy #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vvucetic thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs, this PR lacked an open issue, so I re-opened the original issue. I am putting this in draft until the issue meets the requirements for review outlined in the proposal. |
2 tasks
|
What's the status of this request? I'm trying to deploy an RDS Custom instance using a custom lambda resource which is taking over an hour and causing my nested stacks deployment (update on this case) to time out at 1 hr via the cli deploy option.. Need desperately to get around this issue.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds an option to override waiter config with env vars for cloudformation deploy. Sometimes, some stacks take over 1 hour to provision which makes deploy command exit with failure after 1h although deploy itself remains running.
Mentioned here: #2831
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.