making colors for auto prompt mode configureable #6768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damans227
force-pushed
the
aws-cli-issue-6086
branch
3 times, most recently
from
0d70831
to
af5c402
Compare
Damans227
force-pushed
the
aws-cli-issue-6086
branch
from
af5c402
to
ea76de4
Compare
Damans227
force-pushed
the
aws-cli-issue-6086
branch
from
ec1aa10
to
5b19dd5
Compare
YarinPinyan
reviewed
Apr 12, 2022
tim-finnigan
added
MLH
needs-review
|
Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. I've re-opened the issue associated with this PR, in order to get this scheduled for review the issue would need to get at least 10 👍 reactions on it. |
|
Tests need to pass, and there need to be no conflicts before it can be reviewed. |
justindho
added
the
response-requested
|
@Damans227 In addition to having the existing tests pass, we'll also want new tests against the functionality surrounding configurable colors for auto-prompt mode prior to having a maintainer taking a closer look at this PR. |
|
Closing this PR as it hasn't been active for a couple years now. A new PR should incorporate the feedback above involving tests, and we can continue to track the feature request in #6086. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Configurable colors for auto prompt mode #6086
Description of changes:
aws-clicolors configurable.prompt_toolkit. Plan is to make these color-pallettes configurable.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.