Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amazoncorretto 17 runtime for java #495

Closed
wants to merge 2 commits into from

Conversation

JohnPreston
Copy link
Contributor

@JohnPreston JohnPreston commented Nov 5, 2021

Issue #, if available:

Description of changes:

Adding amazon corretto 17 to the runtimes.

Tested with

docker run -it -v /var/run/docker.sock:/var/run/docker.sock -e "IMAGE_NAME=aws/codebuild/standard:5.0.1" -e "ARTIFACTS=/home/john/artifacts/" -e "SOURCE=/home/john/GIT/pycharm/aws-codebuild-docker-images/ubuntu/standard/5.0" -e "BUILDSPEC=/home/john/GIT/pycharm/aws-codebuild-docker-images/ubuntu/standard/5.0/test.yaml" -e "INITIATOR=john" public.ecr.aws/codebuild/local-builds:latest

And file for test

version: 0.2

phases:
  install:
    runtime-versions:
      java: corretto17
  build:
    commands:
      - java -version

And running mvn with sample application

version: 0.2

phases:
  install:
    runtime-versions:
      java: corretto17
  build:
    commands:
      - java -version
      - mvn clean package

with both al2 and ubuntu, all pass as per my build tests.

@JohnPreston
Copy link
Contributor Author

@leoherran-aws @alemagna-aws
Sorry to bother you guys, just unsure what the process is to get this reviewed ?
Thank you :)

@DaanVleugels
Copy link

DaanVleugels commented Nov 13, 2021

Is it working with Gradle as well? I thought Java 17 needed a Gradle version bump to 7.3 (first version fully supporting java 17)

@JohnPreston
Copy link
Contributor Author

Is it working with Gradle as well? I thought Java 17 needed a Gradle version bump to 7.3 (first version fully supporting java 17)

Do you have a sample test that I can use to test this out ? Most stuff I have tested things with was mvn based :/

@ceardigo
Copy link

Do you have a sample test that I can use to test this out ? Most stuff I have tested things with was mvn based :/

Hello John,

do you mean a sample application using java 17 and gradle? I can provide that if you want.

Thanks

@JohnPreston
Copy link
Contributor Author

Do you have a sample test that I can use to test this out ? Most stuff I have tested things with was mvn based :/

Hello John,

do you mean a sample application using java 17 and gradle? I can provide that if you want.

Thanks

Found an open source project I was interested in that uses gradle so will test that :)

@JohnPreston
Copy link
Contributor Author

@ceardigo FYI I did test since then (sorry I forgot to update this) and gradle tests worked fine.

@akefirad
Copy link

Is there any update about this PR? Thanks.

@rasensio
Copy link

Any update for this PR ?

@hobo05
Copy link

hobo05 commented Feb 18, 2022

Bump! I'm also curious when this can be made available

@JohnPreston
Copy link
Contributor Author

@ecs-jnguyen @kizdebski
Any update on merging this ? Thanks

@JohnPreston
Copy link
Contributor Author

Any luck yet on getting thig through ? It's been a few months now :/

@ym-herby
Copy link

ym-herby commented May 3, 2022

Hi it would be really helpful to get this approved and deployed. Any updates and timeline would be helpful

@leoherran-aws
Copy link
Member

We're actively working on the release of this change. Will update when it's fully released.

@grisotto
Copy link

Any update on this PR?

@JohnPreston
Copy link
Contributor Author

@Dylan-AWS any reason this was not part of the release 8h ago !?

JohnPreston and others added 2 commits June 14, 2022 12:44
Co-authored-by: Jochen Schalanda <jochen@schalanda.name>
Signed-off-by: John Preston <john@ews-network.net>
@JohnPreston
Copy link
Contributor Author

Rebased from master for convenience - just in case.
But when could this be released ?

@mikelhamer
Copy link

plz

@subinataws
Copy link
Contributor

Corretto 17 is supported now with https://github.com/aws/aws-codebuild-docker-images/releases/tag/22.06.30

@subinataws subinataws closed this Jul 1, 2022
@mikelhamer
Copy link

Yay!!!!!!! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet