Support Ruby 2.3 or later #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby since 2.0 has become a lot more stable, and there is no reason this should not be using the newest version. This also simplifies some logic, since all we really care about is whether RUBY_VERSION is less than 2.3.0 or not.
|
Hmmm why again hardcoding the ruby version in the scripts ? Why just not check the version on runtime ? |
|
Just curious if anyone knows the status of this commit? Eager to get an updated agent installed on the latest Ubuntu build. |
|
Isn't this not necessary now that c554a11 is in master? |
|
I'm going to close this PR since it suffers from the same problem as we have today with ruby version 2.0. We are working on releasing a change that doesn't pin the agent to a specific version of ruby. I'll post more updates once we start the rollout. |
|
why close the issue if it's not solved ? Why not to wait for the solution and then close it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby since 2.0 has become a lot more stable, and there is no reason this should not be using the newest version.
This also simplifies some logic, since all we really care about is whether RUBY_VERSION is less than 2.3.0 or not.