You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This only does anything when the file is being processed by mypy or a similar analyzer, so a quick fix for this is for us to just assign a no-op lambda to cast in the import catch statement.
However, I am concerned that our CI did not catch this...I would like to find out what happened there too.
The text was updated successfully, but these errors were encountered:
I am unable to replicate the error that was reported, but in light of this and how we are actually using the typing module, I think that the correct solution here is to simply remove the install dependency. This will require us to add a no-op definition for cast in the modules that we use it, as well as for any of the types that we include in the calls to cast.
As with all of our other modules, in
internal.io_handling
we catch all imports fromtyping
because of issues with CPython 3.5.0 and 3.5.1.aws-encryption-sdk-cli/src/aws_encryption_sdk_cli/internal/io_handling.py
Lines 30 to 35 in ba1f7ea
In 1.1.6, we removed the dependency on
typing
because I had thought that we only used imports fromtyping
in our Python-2-compatible typehints.However, in
internal.io_handling
, we usetyping.cast
.aws-encryption-sdk-cli/src/aws_encryption_sdk_cli/internal/io_handling.py
Line 270 in ba1f7ea
This only does anything when the file is being processed by
mypy
or a similar analyzer, so a quick fix for this is for us to just assign a no-op lambda tocast
in the import catch statement.However, I am concerned that our CI did not catch this...I would like to find out what happened there too.
The text was updated successfully, but these errors were encountered: