Greengrass local auth demo #1831
Conversation
| sslStatus = ( int32_t ) SSL_set_tlsext_host_name( | ||
| pSsl, pOpensslCredentials->sniHostName ); | ||
|
|
||
| if( sslStatus != 1 ) | ||
| { | ||
| LogError( ( "Failed to set server name %s for SNI.", | ||
| pOpensslCredentials->sniHostName ) ); | ||
| } |
There was a problem hiding this comment.
I understand that we had to split platform/posix/transport/src/openssl_posix.c into this file to get around the unit tests preventing modifications that would allow the separate hostname standards. After this PR is merged, the openssl_posix.c unit tests should be removed or modified to allow openssl_posix.c to support both hostname standards.
There was a problem hiding this comment.
We already have plans to remove those; once those are removed, we can merge my other PR on this repo, and then the extra copy will no longer be needed.
There was a problem hiding this comment.
After this demo is merged, I can rebase/fixup the other PR which will de-duplicate them
archigup
force-pushed
the
greengrass_byoca
branch
2 times, most recently
from
d0691e1
to
8bf52f7
Compare
archigup
force-pushed
the
greengrass_byoca
branch
from
8bf52f7
to
93e7b73
Compare
archigup
force-pushed
the
greengrass_byoca
branch
from
0548e2b
to
aee59eb
Compare
| * in eventCallback to reflect the status of the SUBACK sent by the broker. */ | ||
| if( ( returnStatus == EXIT_SUCCESS ) && ( globalSubAckStatus == MQTTSubAckFailure ) ) | ||
| { | ||
| LogInfo( ( "Server rejected subscription request." ) ); |
There was a problem hiding this comment.
Nit: Should this be WARN level?
There was a problem hiding this comment.
Yeah, probably; it was Info, since other demos have it info
archigup
dismissed stale reviews from kstribrnAmzn and paulbartell
via
a92f65d
This PR adds a demo for connecting a device to a Greengrass core using the new feature that allows using custom CAs.
For more info on the feature, see:
https://docs.aws.amazon.com/greengrass/v2/developerguide/greengrass-release-2022-11-15.html
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.