Add proper license attribute per OSI license #155
Conversation
setup.py
Outdated
| @@ -8,11 +8,16 @@ | |||
| setup( | |||
| name='awsiotsdk', | |||
| version='1.0.0-dev', | |||
| license='Apache-2.0', | |||
| license='Apache Software License', | |||
There was a problem hiding this comment.
Maybe this should remain as "Apache-2.0'?
Honestly, this all baffles me 😐
Ask a lawyer?
Here are some github issues where people are just as confused as us regarding what they're supposed to do, because "Apache Software License" is less specific than "Apache-2.0" but it's the only classifier available:
pypi/legacy#91
pypa/trove-classifiers#17
And here's an issue about how the classifier field is recommended in the dev guide, but the APIs still use the license field:
pypi/warehouse#8960
There was a problem hiding this comment.
Different communities have different standardized names for common licenses. The list of valid classifiers for PyPI is at https://pypi.org/classifiers/ and you can search for Apache there to see which is preferred.
Issue #, if available:
N/A
Description of changes:
We should be using the OSI license attribute in the classifier, and the license attribute should match that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.