Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to iotshadow.py json None handling #297

Merged
merged 8 commits into from
Mar 25, 2022
Merged

changes to iotshadow.py json None handling #297

merged 8 commits into from
Mar 25, 2022

Conversation

sbSteveK
Copy link
Contributor

Slight changes to None handling in iotshadow.py

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

awsiot/iotshadow.py Outdated Show resolved Hide resolved
awsiot/iotshadow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@TwistedTwigleg TwistedTwigleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tests pass and I manually ran the Shadow Sample and it works as expected as well 👍

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

test/test_shadowState.py Outdated Show resolved Hide resolved
test/test_shadowState.py Outdated Show resolved Hide resolved
test/test_shadowState.py Outdated Show resolved Hide resolved
test/test_shadowState.py Outdated Show resolved Hide resolved
test/test_shadowState.py Outdated Show resolved Hide resolved
@sbSteveK sbSteveK merged commit fc2f9b0 into main Mar 25, 2022
@sbSteveK sbSteveK deleted the python-json-fix branch March 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants