Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 1.26.0 #441

Merged
merged 1 commit into from
Feb 6, 2023
Merged

chore: bump version to 1.26.0 #441

merged 1 commit into from
Feb 6, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Feb 6, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner February 6, 2023 18:46
@mndeveci mndeveci merged commit f1204ef into develop Feb 6, 2023
@mndeveci mndeveci deleted the mndeveci-patch-1 branch February 6, 2023 19:43
calavera pushed a commit to calavera/aws-lambda-builders that referenced this pull request Feb 8, 2023
hawflau pushed a commit that referenced this pull request Feb 9, 2023
* feat: support rust via cargo

* make black reformat

* use os.path.join in path assertion tests to address windows paths

* address pylint ci errors

* fix reformatted list comprehensions

* try passing rust-lld linker on windows

* update rust cargo design doc. windows support was added and tested

* add test for cargo workspaces project

* reformat test sources

* build with musl on linux because glibc may differ on lambda

* update linux copy and bin paths

* update make test again, use the version appveyor is complaining about

* update integration tests for rust cargo with latest aws rust runtime interfaces

* align TestCustomMakeWorkflow integ test assumptions with appveyor reality

* make x86_64-unknown-linux-musl a const for the rust cargo workflow

* add integ test for failing cargo rust build

* Update Rust workflow to use cargo-lambda

Cargo-lambda takes care of cross compiling using Zig as linker.
This works on Windows, Linux, and MacOS natively.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix deprecation warnings.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Install Zig on Windows manually

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Print Zig version on Windows

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update version of cargo-lambda

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Run windows tests in powershell

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix powershell env notation

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Print clang version on windows

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix env variable name

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Try new version of zigbuild that fixes some linker issues on Windows.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update releases URL.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Upgrade LLVM and clang

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update visual studio image

To check if that makes any difference.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Change the visual studio image everywhere.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Revert upgrade changes

They didn't fix the problem

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Print environment

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update to Visual Studio 2022

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix python variable

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix package urls

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update missing vs 2019 reference.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Change windows package suffix

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update cargo-lambda to version 0.9.0

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Go back to the original VS version.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Cleanup options

- Use architecture to setup the right build target.
- Don't require `--bin` flag, the default behaviour should work for the majority of functions.
- Add flags option to provide a list of additional flags for projects that need extra configuration, like projects within a workspace.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add integration test with cargo_lambda_flags

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Detect binaries when the project only includes one function.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Bring back handler as an optional argument.

It saves some duplicated flags for working with workspaces.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Ignore errors if directory doesn't exist.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add debug logs

Set RUST_LOG=debug when debug is enabled.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Log the artifact destination path.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add missing comma

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Print out and err in the log when debug is enabled

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Only set RUST_LOG when it's not already set

Log it's value, so users know what's set at.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add experimentalCargoLambda feature flag.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add integration test for multi-function projects.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Remove type hints

They're causing false positives in Python 3.9 with pylint.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add new CI steps for GHA

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add build_in_source_support

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Test rust logger

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix assertion

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Don't fail fast

Signed-off-by: David Calavera <david.calavera@gmail.com>

* fix: Fix failing esbuild integration tests (#423)

* fix: Fix failing esbuild integration tests

* Replace npm ci with npm install

* Remove default shell

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Revert "Remove default shell"

This reverts commit 478c3b6.

* Add check to ensure that Cargo Lambda is installed.

Include a link to the gettings started guide that gives direct installation instructions based on the platform.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* feat: Add support for mjs files with esbuild (#427)

* feat: Add support for mjs files with esbuild

* Black reformat

* Test Cargo Lambda check

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Don't redefine which

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Organize code in more modules

This structure follows other workflows, and provides better testeability.

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Add more documentation

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Format code

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Capture exception

Signed-off-by: David Calavera <david.calavera@gmail.com>

* chore: Remove type/bug label for Bug Issue Template (#425)

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>

* Clean design doc and tests

Signed-off-by: David Calavera <david.calavera@gmail.com>

* chore: Version bump to 1.25.0 (#429)

* refactor: assign each workflow a default build directory (#428)

* fix: remove unused symlinking (#432)

* chore: Move to ruff from pylint (#435)

When we started the project we defaulted to use pylint. Pylint has served it's
purpose but it pretty slow. Ruff is a newer linter in the python
ecosystem but is written in Rust. This makes Ruff was faster than pylint.
On my machine (while testing in SAM CLI), pylint took about 70s to lint the repo
but with ruff it took .04s.

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* chore: Enable pylint within ruff (#436)

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* refactor: esbuild refactor for readability (#433)

* feat: use build_dir in esbuild workflow to support building in source (#437)

* Fix formatting

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update build in source settings

Signed-off-by: David Calavera <david.calavera@gmail.com>

* fix: remove python3.6 support (#434)

* chore: bump version to 1.26.0 (#441)

* Remove default value for subprocess_cargo_lambda

Signed-off-by: David Calavera <david.calavera@gmail.com>

* feat: Pin ruff version, add dependabot config (#442)

* feat: Pin ruff version, add dependabot config to keep our dependencies up to date

* Exlude isort and flake8 from dependabot updates

* feat: Add sources content flag to supported esbuild options (#439)

* Better process management

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Make release mode the default

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Remove already default None

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Turn debug message into warning

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Update documentation format

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Fix formatting

Signed-off-by: David Calavera <david.calavera@gmail.com>

* Preserve binary permissions

Use copy2 instead of copyfile

Signed-off-by: David Calavera <david.calavera@gmail.com>

---------

Signed-off-by: David Calavera <david.calavera@gmail.com>
Co-authored-by: softprops <d.tangren@gmail.com>
Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com>
Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
Co-authored-by: Ruperto Torres <86501267+torresxb1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants