Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatchEvent should be renamed #479

Closed
mostafafarzaneh opened this issue Jan 10, 2023 · 1 comment · Fixed by #537
Closed

CloudWatchEvent should be renamed #479

mostafafarzaneh opened this issue Jan 10, 2023 · 1 comment · Fixed by #537
Labels
documentation type/events issue or feature request related to the events package type/ux

Comments

@mostafafarzaneh
Copy link

I think because the documentation suggests using EventBridge over CloudWatchEvent, I thought that it is better to rename CloudWatchEvent to something that includes EventBridge maybe?
@bmoffatt bmoffatt added documentation type/events issue or feature request related to the events package type/ux labels Mar 22, 2023
@bmoffatt
Copy link
Collaborator

Maybe a type alias would do here. As far as I know the structure of these events hasn't changed, just the branding.

mateusmarquezini added a commit to mateusmarquezini/aws-lambda-go that referenced this issue Dec 17, 2023
@mateusmarquezini
aws#479 CloudWatchEvent renamed to EventBridgeEvent
532af4b
@mateusmarquezini mateusmarquezini mentioned this issue Dec 17, 2023
Merged
mateusmarquezini added a commit to mateusmarquezini/aws-lambda-go that referenced this issue Dec 17, 2023
@mateusmarquezini
aws#479 CloudWatchEvent renamed to EventBridgeEvent
de0ba7c
mateusmarquezini added a commit to mateusmarquezini/aws-lambda-go that referenced this issue Dec 19, 2023
@mateusmarquezini
aws#479 code improvements after code review
ecb3965
mateusmarquezini added a commit to mateusmarquezini/aws-lambda-go that referenced this issue Dec 22, 2023
@mateusmarquezini
aws#479 small fixes after code review
911280a
mateusmarquezini added a commit to mateusmarquezini/aws-lambda-go that referenced this issue Dec 23, 2023
@mateusmarquezini
aws#479 small fix after code review
7d417dd
bmoffatt pushed a commit that referenced this issue Jan 4, 2024
@mateusmarquezini
[479] CloudWatchEvent renamed to EventBridgeEvent (#537)
50dbfb1 
* #479 CloudWatchEvent renamed to EventBridgeEvent

* #479 CloudWatchEvent renamed to EventBridgeEvent

* #479 code improvements after code review

* #479 small fixes after code review

* #479 small fix after code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation type/events issue or feature request related to the events package type/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[479] CloudWatchEvent renamed to EventBridgeEvent mateusmarquezini/aws-lambda-go
2 participants
@bmoffatt @mostafafarzaneh