Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: V1 and V2 of the API Gateway custom authorizer event and the si… #166

Merged
merged 4 commits into from Oct 7, 2020
Merged

feat: V1 and V2 of the API Gateway custom authorizer event and the si… #166

merged 4 commits into from Oct 7, 2020

Conversation

msailes
Copy link
Collaborator

@msailes msailes commented Sep 25, 2020

…mplified IAM policy.

Issue #, if available:

n/a

Description of changes:

Pojos for the API Gateway custom authorizers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

private String requestId;
private String routeKey;
private String stage;
private String time; // "time": "12/Mar/2020:19:03:58 +0000",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an object?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better off as a ZonedDateTime object

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, ZonedDateTime (de)serialization is not currently supported in the Java runtimes, either String or org.joda.time.DateTime (currently preferred) should be fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is possible to write a custom StdDeserializer to achieve this, but we dont want to do that ? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately registering a custom mapper in this library is not currently supported by the Java runtime and this is probably the best solution we can implement at this time IMHO

@msailes
Copy link
Collaborator Author

msailes commented Oct 5, 2020

Tested

@carlzogh carlzogh merged commit e21d4ba into aws:master Oct 7, 2020
@carlzogh
Copy link
Contributor

carlzogh commented Oct 7, 2020

Thanks a lot for your continued contributions @msailes! 😃

@msailes msailes deleted the api-gw-v2-custom-auth branch October 8, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants