Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RSA to FIPS Approved Functions #196

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Migrate RSA to FIPS Approved Functions #196

merged 3 commits into from
Jul 20, 2023

Conversation

skmcgrail
Copy link
Member

Before

RSA-1192-PKCS1-SHA256-sign-128-bytes/AWS-LC
                        time:   [607.64 µs 607.89 µs 608.15 µs]
Found 15 outliers among 100 measurements (15.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  3 (3.00%) high mild
  4 (4.00%) high severe

RSA-1192-PKCS1-SHA256-verify-128-bytes/AWS-LC
                        time:   [27.770 µs 27.771 µs 27.773 µs]
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild

Benchmarking RSA-1768-PKCS1-SHA256-sign-128-bytes/AWS-LC: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.4s, enable flat sampling, or reduce sample count to 50.
RSA-1768-PKCS1-SHA256-sign-128-bytes/AWS-LC
                        time:   [1.8436 ms 1.8476 ms 1.8528 ms]
Found 14 outliers among 100 measurements (14.00%)
  3 (3.00%) high mild
  11 (11.00%) high severe

RSA-1768-PKCS1-SHA256-verify-128-bytes/AWS-LC
                        time:   [67.400 µs 67.402 µs 67.404 µs]
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  1 (1.00%) high severe

RSA-1192-PKCS1-SHA384-sign-128-bytes/AWS-LC
                        time:   [607.59 µs 607.82 µs 608.04 µs]
Found 15 outliers among 100 measurements (15.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  4 (4.00%) high mild
  3 (3.00%) high severe

RSA-1192-PKCS1-SHA384-verify-128-bytes/AWS-LC
                        time:   [28.051 µs 28.073 µs 28.111 µs]
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low mild
  3 (3.00%) high mild
  2 (2.00%) high severe

RSA-2347-PKCS1-SHA512-sign-128-bytes/AWS-LC
                        time:   [4.0656 ms 4.0720 ms 4.0789 ms]

RSA-2347-PKCS1-SHA512-verify-128-bytes/AWS-LC
                        time:   [65.898 µs 65.900 µs 65.902 µs]
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high severe

RSA-1192-PKCS1-SHA512-sign-128-bytes/AWS-LC
                        time:   [607.34 µs 607.55 µs 607.77 µs]
Found 15 outliers among 100 measurements (15.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  4 (4.00%) high mild
  3 (3.00%) high severe

RSA-1192-PKCS1-SHA512-verify-128-bytes/AWS-LC
                        time:   [28.053 µs 28.055 µs 28.056 µs]
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) low mild
  1 (1.00%) high severe

After

RSA-1192-PKCS1-SHA256-sign-128-bytes/AWS-LC
                        time:   [607.10 µs 607.32 µs 607.53 µs]
                        change: [-0.7713% -0.1069% +0.5047%] (p = 0.80 > 0.05)
                        No change in performance detected.
Found 15 outliers among 100 measurements (15.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  4 (4.00%) high mild
  3 (3.00%) high severe

RSA-1192-PKCS1-SHA256-verify-128-bytes/AWS-LC
                        time:   [28.356 µs 28.357 µs 28.358 µs]
                        change: [+2.1055% +2.1136% +2.1218%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  4 (4.00%) low mild
  4 (4.00%) high mild
  4 (4.00%) high severe

Benchmarking RSA-1768-PKCS1-SHA256-sign-128-bytes/AWS-LC: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.5s, enable flat sampling, or reduce sample count to 50.
RSA-1768-PKCS1-SHA256-sign-128-bytes/AWS-LC
                        time:   [1.8459 ms 1.8466 ms 1.8474 ms]
                        change: [-1.5243% -0.7902% -0.0895%] (p = 0.03 < 0.05)
                        Change within noise threshold.
Found 19 outliers among 100 measurements (19.00%)
  14 (14.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe

RSA-1768-PKCS1-SHA256-verify-128-bytes/AWS-LC
                        time:   [67.624 µs 67.625 µs 67.626 µs]
                        change: [+0.3265% +0.3344% +0.3454%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

RSA-1192-PKCS1-SHA384-sign-128-bytes/AWS-LC
                        time:   [607.45 µs 607.66 µs 607.88 µs]
                        change: [-0.6655% -0.0244% +0.6128%] (p = 0.94 > 0.05)
                        No change in performance detected.
Found 14 outliers among 100 measurements (14.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  3 (3.00%) high mild
  3 (3.00%) high severe

RSA-1192-PKCS1-SHA384-verify-128-bytes/AWS-LC
                        time:   [28.594 µs 28.595 µs 28.596 µs]
                        change: [+1.8223% +1.8933% +1.9426%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
  3 (3.00%) low mild
  3 (3.00%) high mild
  3 (3.00%) high severe

RSA-2347-PKCS1-SHA512-sign-128-bytes/AWS-LC
                        time:   [4.0656 ms 4.0717 ms 4.0782 ms]
                        change: [-0.2449% -0.0078% +0.2187%] (p = 0.94 > 0.05)
                        No change in performance detected.

RSA-2347-PKCS1-SHA512-verify-128-bytes/AWS-LC
                        time:   [66.269 µs 66.271 µs 66.274 µs]
                        change: [+0.5530% +0.5622% +0.5707%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
  1 (1.00%) high severe

RSA-1192-PKCS1-SHA512-sign-128-bytes/AWS-LC
                        time:   [607.17 µs 607.39 µs 607.61 µs]
                        change: [-0.6500% -0.0177% +0.6796%] (p = 0.96 > 0.05)
                        No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
  7 (7.00%) low severe
  1 (1.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe

RSA-1192-PKCS1-SHA512-verify-128-bytes/AWS-LC
                        time:   [28.496 µs 28.498 µs 28.499 µs]
                        change: [+1.5693% +1.5844% +1.5964%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) low mild
  3 (3.00%) high mild

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner July 18, 2023 21:31
samuel40791765
samuel40791765 reviewed Jul 20, 2023
View reviewed changes
aws-lc-rs/src/rsa.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/rsa.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/rsa.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/rsa.rs Outdated Show resolved Hide resolved
aws-lc-rs/src/rsa.rs Outdated Show resolved Hide resolved
@skmcgrail skmcgrail merged commit 6a4d598 into aws:fips-api-changes Jul 20, 2023
71 of 72 checks passed
@skmcgrail skmcgrail deleted the rsa-fips branch July 20, 2023 19:47
skmcgrail added a commit that referenced this pull request Oct 20, 2023
@skmcgrail
FIPS Feature Improvements (#244)
fe5d0de 
* Migrate ECDSA to FIPS Approved Functions (#188)
* Migrate RSA to FIPS Approved Functions (#196)
* Migrate Agreement to FIPS Approved Functions (#198)
* FIPS AEAD API Types (#207)
* Refactor HKDF for FIPS (#217)
* FIPS Status Indicator (#216)
* Migrate Ed25519 key generation to EVP_PKEY_keygen (#224)
* FIPS Usage Documentation (#231)
* Support for TLS 1.2 PRF (#232)
* Documentation cleanup (#243)
* Cleanup for fips-api-changes branch (#248)
hansonchar pushed a commit to hansonchar/aws-lc-rs that referenced this pull request Oct 21, 2023
@skmcgrail
FIPS Feature Improvements (aws#244)
08d07ee 
* Migrate ECDSA to FIPS Approved Functions (aws#188)
* Migrate RSA to FIPS Approved Functions (aws#196)
* Migrate Agreement to FIPS Approved Functions (aws#198)
* FIPS AEAD API Types (aws#207)
* Refactor HKDF for FIPS (aws#217)
* FIPS Status Indicator (aws#216)
* Migrate Ed25519 key generation to EVP_PKEY_keygen (aws#224)
* FIPS Usage Documentation (aws#231)
* Support for TLS 1.2 PRF (aws#232)
* Documentation cleanup (aws#243)
* Cleanup for fips-api-changes branch (aws#248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel40791765 samuel40791765 samuel40791765 approved these changes

@justsmth justsmth justsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skmcgrail @samuel40791765 @justsmth