Add support of Octet String and X509 bytes encoding (#255) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansonchar
force-pushed
the
main-x509
branch
4 times, most recently
from
227e317
to
1302642
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 95.65% 95.74% +0.08%
==========================================
Files 57 58 +1
Lines 7759 7983 +224
==========================================
+ Hits 7422 7643 +221
- Misses 337 340 +3 ☔ View full report in Codecov by Sentry. |
hansonchar
force-pushed
the
main-x509
branch
2 times, most recently
from
fc6a142
to
56a0491
Compare
There was a problem hiding this comment.
This is exposing taking different encodings as a new parameter and function (new_with_encoding) rather than adding a new new_with_x509 creation function, like that PR did (once):
fn from_private_key_der(alg: &'static EcdsaSigningAlgorithm, key: &[u8]) -> Result<Self, KeyRejected>;
I think generally speaking either is fine but it is a slight deviation. I think in most cases the caller is going to know for sure what they have so adding extra functions in the public API for different encodings rather than having an Encoding struct + constants might be cleaner.
But, no strong opinions.
Will change. |
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 27, 2023
hansonchar
commented
Oct 27, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 27, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 27, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 31, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 31, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Oct 31, 2023
hansonchar
force-pushed
the
main-x509
branch
2 times, most recently
from
3d8b907
to
662c9e7
Compare
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Nov 11, 2023
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Nov 11, 2023
hansonchar
force-pushed
the
main-x509
branch
from
2ee6ef3
to
39d9f5a
Compare
hansonchar
force-pushed
the
main-x509
branch
from
fda9de1
to
ce481d6
Compare
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 13, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 13, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 13, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
force-pushed
the
main-x509
branch
from
ce481d6
to
ff308cd
Compare
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 16, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 16, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 16, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
force-pushed
the
main-x509
branch
from
ff308cd
to
a95a456
Compare
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 19, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 19, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 19, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
force-pushed
the
main-x509
branch
from
a95a456
to
c21d6b1
Compare
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 22, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 22, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Dec 22, 2023
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 5, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 5, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 5, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 9, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 9, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 9, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 11, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
hansonchar
pushed a commit
to hansonchar/aws-lc-rs
that referenced
this pull request
Jan 11, 2024
Address Mark's review comments at aws#256 Address Mark's 2nd round of review comments at aws#256 Computes the public key in X509 format from the private key used for key agreement. Fix doc per Mark's feedback Move Encoding and EncodingID from agreement.rs to public_key.rs so they can be reused them in both signature::UnparsedPublicKey and agreement::UnparsedPublicKey Move evp_pkey_from_x509_pubkey from ec.rs to public_key.rs as it can be reused for not only EC public keys but also RSA public keys.
|
I've stashed this PR contents at https://github.com/aws/aws-lc-rs/tree/hansonchar/main-x509 until we have time to review this work as part of the broader service teams' requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #255
Description of changes:
Currently only octet string encoding is supported for the input peer public key for key agreement. This makes it difficult to interoperate with other platforms such as Java where the public key is output in X509 encoding. This change supports the input of peer public key in both Octet String and X509 encoding for key agreement purposes.
Call-outs:
Currently the output bytes of a EC public key from
aws-lc-rsis always in octet string encoding. It should also provide the API to output the public key in X509 DER encoding as an option. Will however address this in a separate issue and PR.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.