Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exposure of dry-run publish failures #333

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 30, 2024

Issues:

N/A

Description of changes:

  • Separate CI tasks to dry-run publish each crate independently.
    • We were previously lumping all 3 crates into a single task, and then ignoring the expected failure b/c aws-lc-rs depended on not-yet-released versions of our sys crates.

Call-outs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 30, 2024 15:43
@justsmth justsmth force-pushed the ci-pub-dry-run branch 2 times, most recently from 4e7ec23 to 47d9b73 Compare January 30, 2024 15:52
@justsmth
Copy link
Contributor Author

justsmth commented Jan 30, 2024

@justsmth justsmth force-pushed the ci-pub-dry-run branch 2 times, most recently from 4abb561 to 87bd1d9 Compare January 30, 2024 16:45
@justsmth
Copy link
Contributor Author

The failure I was hoping for: https://github.com/aws/aws-lc-rs/actions/runs/7714541187/job/21027029187?pr=333#step:9:110

...
   Compiling aws-lc-fips-sys v0.12.1 (D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1)
error: failed to run custom build command for `aws-lc-fips-sys v0.12.1 (D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1)`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_DEV_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1\target\debug\build\aws-lc-fips-sys-af43f87486267e88\build-script-main` (exit code: 101)
  --- stdout
  cargo:rustc-cfg=use_bindgen_generated

  --- stderr

  thread 'main' panicked at builder\cmake_builder.rs:106:30:
  Failed to run vccarsall.bat.

@justsmth justsmth merged commit cc9f7ee into aws:main Jan 30, 2024
139 of 142 checks passed
@justsmth justsmth deleted the ci-pub-dry-run branch January 30, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants