Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Android FIPS build on armv8 (#299)
### Issues: Resolves #192 ### Description of changes: * Clang with the Android NDK doesn't compile with `-Werror` on clang due to implicit addition of `-Wa,noexecstack`. Since `--Wa,--noexecstack` is not used during the preprocessor step (because assembler is not invoked), Clang reports that argument as unused. Added a removal the flag during FIPS builds for Android. Context: android/ndk#171 * CMAKE inserts a `\` before whitespaces in arguments, which Android line does not recognize when using `add_custom_command`. This caused `${CMAKE_ASM_COMPILER}` to fail during the preprocessing step. Replacing whitespaces with `;` fixes this. Context: https://stackoverflow.com/questions/8925396/why-does-cmake-prefixes-spaces-with-backslashes-when-executing-a-command By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
- Loading branch information