Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explanation of ignore-daemon-sets flag #194

Merged

Conversation

takanabe
Copy link
Contributor

The ignore-daemon-sets flag is compatible with kubectl drain --ignore-daemonsets. It literally ignores daemon sets to proceed a drain. However, the description of ignore-daemon-sets flag says

If true, drain daemon sets when a spot interrupt is received.

This is the opposite meaning of what exactly this flag wants to do.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files          10       10           
  Lines         774      774           
=======================================
  Hits          629      629           
  Misses        129      129           
  Partials       16       16           
Impacted Files Coverage Δ
pkg/config/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e769d9e...8bd4b25. Read the comment docs.

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!!

@bwagner5 bwagner5 merged commit bc39bfb into aws:master Jul 10, 2020
@takanabe takanabe deleted the tw/fix-explanation-of-ignore-daemon-sets-flag branch July 11, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants