fixed and improved region detection within queue url #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haugenj
reviewed
Apr 9, 2021
| } | ||
| } | ||
| } | ||
| return "" |
There was a problem hiding this comment.
will this lead to an error?
There was a problem hiding this comment.
if they do end up changing the queue urls or something, maybe we should at least log here
There was a problem hiding this comment.
oh and to answer the first question, yes it will lead to an aws sdk error that the region is undefined
| func getRegionFromQueueURL(queueURL string) string { | ||
| for _, partition := range endpoints.DefaultPartitions() { | ||
| for regionID := range partition.Regions() { | ||
| if strings.Contains(queueURL, regionID) { |
There was a problem hiding this comment.
it's not likely; but if someone named their queue us-west-2 when it was actually in e.g. ap-southeast-1 then this could have a false positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#390
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.