Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old versions of k8s remove from testing #511

Merged
merged 18 commits into from
Oct 18, 2021
Merged

Old versions of k8s remove from testing #511

merged 18 commits into from
Oct 18, 2021

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Oct 14, 2021 •
edited

Issue #, if available: #507

Description of changes:

  1. Removed old k8s versions from testing
  2. Added new k8s version 1.22 in testing
  3. Remove pre-1.14 artifacts

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ngoyal16
Old versions of k8s remove from testing
0a35503 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
snay2
snay2 suggested changes Oct 14, 2021
View reviewed changes
test/k8s-local-cluster-test/run-test Outdated Show resolved Hide resolved
@ngoyal16
default version sync
5f9c67e 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16 ngoyal16 requested a review from snay2 October 15, 2021 01:30
@ngoyal16
pre-1.14 artifacts removed
01a5643 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
pre-1.14 artifacts removed
9143b94 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
pre-1.14 artifacts removed
44a91bf 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
pre-1.14 artifacts removed
9ea816f 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
pre-1.14 artifacts removed
c7a4136 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@snay2
Copy link
Contributor

snay2 commented Oct 15, 2021

@bwagner5 I'm thinking this change should go into a 1.14 release of NTH rather than 1.13.4, since removing support for k8s < 1.14 could be a breaking change for some customers. Should we do a release of 1.13.4 first and then merge this afterward (and maybe also #506, since it's also a large change)?

snay2
snay2 reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of all this! Once the tests pass and we decide on the release strategy, I'll approve and merge.

@snay2 snay2 linked an issue Oct 15, 2021 that may be closed by this pull request
k8s version 1.16 is no longer supported by EKS. #507
Closed
@snay2
Copy link
Contributor

snay2 commented Oct 15, 2021

Ran the end-to-end tests on my local machine and they all passed. Not sure why they keep failing in GitHub Actions, but I'm comfortable with merging this once we're ready.

@bwagner5
Copy link
Contributor

@snay2 Yep, that sounds good on putting this v1.14.0

@ec2-bot
Upgrade k8s image to 1.22.2 to avoid kind errors
5993d54 
Also allow more verbose kind output to ease debugging
@ngoyal16
Merge pull request #1 from snay2/upgrade-1.22.2
11e2381 
Upgrade k8s image to 1.22.2 to avoid kind errors
@snay2
Copy link
Contributor

snay2 commented Oct 15, 2021 •
edited

Bother. I'm getting the same error locally now that the build here is getting:

Error: failed to install CRD crds/crd-alertmanager.yaml: unable to recognize "": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1"

Looks like 1.22 drops the "apiextensions.k8s.io/v1beta1" in favor of "apiextensions.k8s.io/v1": https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/

@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Oct 15, 2021 •
edited

Just seen that.. Will fix it and update tomorrow morning

@ngoyal16
Copy link
Contributor Author

@snay2 i have fixed it at known places. please check.

@ngoyal16
post-1.21 api version fix in prometheus-operator
d6a4c55 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Oct 16, 2021 •
edited

@snay2 can we use latest version of helm chart for prometheus-operator as the current is deprecated already?

  1. https://github.com/aws/aws-node-termination-handler/tree/main/config/helm/prometheus-operator
  2. https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack

@ngoyal16
upgrade prometheus-operator to the latest version
3741034 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
disable prometheus dependencies.
b5975ed 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
disable prometheus dependencies.
f3a99d2 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
disable prometheus dependencies.
578e680 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
old prometheus-operator removed.
d7f5a35 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
grafana components removed from kube-prometheus-stack helm chart.
f241080 
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
Copy link
Contributor Author

@snay2 all test are passed with new prometheus operator.

@ngoyal16
Copy link
Contributor Author

@snay2 can you rerun failed step as it passed in my gut workflow. Not sure why failed

snay2
snay2 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for seeing this through.

@snay2 snay2 merged commit 2518f22 into aws:main Oct 18, 2021
@ngoyal16 ngoyal16 deleted the old-k8s-tests branch October 19, 2021 05:41
@ec2-bot ec2-bot mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snay2 snay2 snay2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s version 1.16 is no longer supported by EKS.
4 participants
@ngoyal16 @snay2 @bwagner5 @ec2-bot