feat(chart): Add servicemonitor #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
|
/assign @bwagner5 |
|
@bwagner5 I've spotted a number of issues with the Helm chart that should probably be tidied up, would you be interested in a PR for that after this has been merged? |
brycahta
approved these changes
Oct 22, 2021
| @@ -100,6 +95,11 @@ Parameter | Description | Default | |||
| `workers` | The maximum amount of parallel event processors | `10` | |||
| `replicas` | The number of replicas in the NTH deployment when using queue-processor mode (NOTE: increasing replicas may cause duplicate webhooks since NTH pods are stateless) | `1` | |||
| `podDisruptionBudget` | Limit the disruption for controller pods, requires at least 2 controller replicas | `{}` | |||
| `serviceMonitor.create` | If `true`, create a ServiceMonitor (this requires enableSqsTerminationDraining and enablePrometheusServer to be set) | `false` | |||
There was a problem hiding this comment.
nit: you don't need to include the bit about enableSqsTerminationDraining because these configs are in their respective sections already(QP vs IMDS)
Yes, absolutely! :) thanks |
@bwagner5 I'll wait for this to be merged and then open a new PR based on the updated main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516.
Description of changes:
Serviceresource ifenableSqsTerminationDraining=trueandenablePrometheusServer=trueserviceMonitorconfig to allow the creation of aServiceMonitorresource viaserviceMonitor.enabled=trueifenableSqsTerminationDraining=trueandenablePrometheusServer=truePodMonitorresource viapodMonitor.enabled=trueifenableSqsTerminationDraining=falseandenablePrometheusServer=trueBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.