Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev guide and resources #660

Merged
merged 13 commits into from
Jul 21, 2022
Merged

update dev guide and resources #660

merged 13 commits into from
Jul 21, 2022

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Jul 13, 2022

Issue #, if available:

Description of changes:

  • make apply now uses the value of CLUSTER_NAMESPACE rather than a hardcoded namespace
  • EventBridge rule name suffixes have been shorted to reduce likelihood of exceeding length limitation
  • EKS cluster template now specifies Kuberentes v1.22
  • ko is now installed from a pre-built binary rather than using go install to workaround a build issue in the ko project
  • Dev guide now has instructions for verifying that an existing cluster has an IAM OIDC provider, and how to add one
  • Dev guide now has steps to run make help and make test
  • Dev guide now has an optional step to display all NTH v2 resources in the cluster
  • Dev guide now has a list of tools used
  • Dev guide steps and instructions have been revised and improved
  • Terminator objects will now appear in the "all" category (e.g. kubectl get all -n <namespace>)
  • Terminator template now specifies a namespace taken from CLUSTER_NAMESPACE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad marked this pull request as ready for review July 13, 2022 19:00
@cjerad cjerad requested a review from a team as a code owner July 13, 2022 19:00
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this resolves the issues I had.

Makefile Show resolved Hide resolved
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the issues that I had earlier, as discussed offline, creating bin directory should be included in makefile.

Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👍

@pdk27
Copy link
Contributor

pdk27 commented Jul 19, 2022

LGTM 👍 Thanks, Jerad.

Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@AustinSiu AustinSiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks Jerad 👍

@cjerad cjerad merged commit 3a06701 into aws:v2 Jul 21, 2022
@cjerad cjerad deleted the fix-dev-guide branch July 21, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
V2
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

6 participants