fix(sqs): log itn event messageid correctly #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snay2
suggested changes
Sep 6, 2022
acobaugh
force-pushed
the
fix/error-logging
branch
from
e688a08
to
0640a70
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This fixes the logging so we log the MessageId, not a binary representation of the pointer. Otherwise we get messages like:
2022/09/06 19:22:45 ERR error processing interruption events error="some interruption events for message Id 1100000000000000001111000101100011101000 could not be processed"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.