Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync-readme-to-ecr-public.sh script #698

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Oct 5, 2022

Issue #, if available:

Description of changes:

Add script that uploads the contents of README.md (up to the max allowed length) to the ECR public repos for the controller and webhook.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad marked this pull request as ready for review October 5, 2022 19:57
@cjerad cjerad requested a review from a team as a code owner October 5, 2022 19:57
Makefile Show resolved Hide resolved
scripts/sync-readme-to-ecr-public.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


.PHONY: previous-release-tag
previous-release-tag: ## Get tag of second most recent release.
@git describe --tags --abbrev=0 `git rev-parse --abbrev-ref HEAD`^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution! This assumes that HEAD is the location of the release tag, which is the same assumption that GitHub will make about where to cut the release, so I like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
V2
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants