Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃馃 v2.0.0-alpha release prep #707

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Oct 18, 2022

馃馃 Auto-generated PR for v2.0.0-alpha release. Updating release versions in repo.

@cjerad cjerad added release-prep PRs opened for release preparation (i.e. release version updates in repo) 馃 auto-generated馃 Auto-generated PRs labels Oct 18, 2022
@cjerad cjerad marked this pull request as ready for review October 18, 2022 16:57
@cjerad cjerad requested a review from a team as a code owner October 18, 2022 16:57
@cjerad cjerad merged commit cc36c3d into aws:v2 Oct 18, 2022
@cjerad cjerad deleted the pr/v2.0.0-alpha-release branch October 18, 2022 18:43
@stevehipwell
Copy link
Contributor

@cjerad I've just had a very quick look at the Helm chart for v2 and it jumped out at me that you've added the CRD into the templates folder rather than the crds folder. If you're interested I'd be happy to take a look at the chart in more detail (I refactored the v1 chart)?

@cjerad
Copy link
Contributor Author

cjerad commented Oct 19, 2022

the CRD into the templates folder rather than the crds folder

@stevehipwell Thanks for taking a look and providing feedback. The CRD is currently templated (see here), so the templates directory seemed appropriate based on the Helm docs description: There is now a special directory called crds that you can create in your chart to hold your CRDs. These CRDs are not templated

@stevehipwell
Copy link
Contributor

@cjerad the docs are specifically saying that you should use the crds folder and that Helm will no longer template CRD; this was an anti-pattern for Helm v2 and was explicitly called out as not to be used by Helm v3 and the v2 chart specification.

It not worth having Helm install the CRDs unless you're just giving a chart a quick test, the crds folder allows for this use case and also acts as the definitive source for the correct CRD to install via an alternate method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃 auto-generated馃 Auto-generated PRs release-prep PRs opened for release preparation (i.e. release version updates in repo)
Projects
V2
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants