Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Go 1.19 #726

Merged
merged 5 commits into from
Nov 21, 2022
Merged

upgrade to Go 1.19 #726

merged 5 commits into from
Nov 21, 2022

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Nov 18, 2022

Issue #, if available:

Description of changes:

Upgrade Go to 1.19

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

snay2
snay2 previously approved these changes Nov 19, 2022
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license check is failing, saying that NTH itself is missing a license (?), but otherwise this looks good.

@snay2 snay2 marked this pull request as ready for review November 21, 2022 22:28
@snay2 snay2 requested a review from a team as a code owner November 21, 2022 22:28
@snay2 snay2 merged commit cde85f3 into aws:main Nov 21, 2022
@snay2 snay2 added the Pending-Release Pending an NTH or eks-charts release label Nov 21, 2022
@snay2
Copy link
Contributor

snay2 commented Nov 22, 2022

Released in NTH v1.18.0 (Helm chart version v0.20.0).

@snay2 snay2 removed the Pending-Release Pending an NTH or eks-charts release label Nov 22, 2022
@cjerad cjerad deleted the upgrade-go branch November 30, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants