Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't construct an IMDS client when in Queue Processor mode #747

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

johngmyers
Copy link
Contributor

Issue #, if available:

None

Description of changes:

This is a minor cleanup. It skips creating an IMDS client when in Queue Processor mode and makes it clearer that there is not metadata available.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johngmyers johngmyers requested a review from a team as a code owner December 10, 2022 22:55
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slight refactor of #735. I like the simplification.

@snay2 snay2 requested a review from jillmon December 14, 2022 16:22
@snay2
Copy link
Contributor

snay2 commented Dec 22, 2022

Fixed merge conflict caused by one of the other PRs this afternoon. After the tests pass we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants