Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Table Header does not append the the item account #919

Closed
mteichtahl opened this issue Jun 28, 2023 · 2 comments
Closed

Custom Table Header does not append the the item account #919

mteichtahl opened this issue Jun 28, 2023 · 2 comments
Labels
bug Something isn't working released

Comments

@mteichtahl
Copy link
Contributor

Describe the bug
When using a custom header in a Table, the item counter is presented below the custom header with no way to append it.

image

Versions
@aws-northstar/ui@npm:1.1.2

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Code

<Table
      columnDefinitions={columnDefinitions}
      header={
        <Header
          variant="h2"
          info={<Link variant="info">Info</Link>}
          actions={<SpaceBetween direction="horizontal" size="xs">
            <Button disabled={editButtonDisabled}>Secondary button</Button>
            <Button variant="primary">
              Create new tenant
            </Button>
          </SpaceBetween>}
        >
          Tenants
        </Header>}

Expected behavior

The item counter should be appended to the custom header

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
all

Smartphone (please complete the following information):
all

Additional context
Nil

@jessieweiyi
Copy link
Contributor

A PR has been created to support more header props. Suggest to use the build-in header so that the counter will be rendered.

After the PR is merged and new version is released, the code can be updated to use build-in header.

<Table
      columnDefinitions={columnDefinitions}
      header='Tenants'
      headerVariant='h2'
      info={<Link variant="info">Info</Link>}
      actions={<SpaceBetween direction="horizontal" size="xs">
            <Button disabled={editButtonDisabled}>Secondary button</Button>
            <Button variant="primary">
              Create new tenant
            </Button>
          </SpaceBetween>} 
/>

@aws-prototyping-bot
Copy link
Collaborator

🎉 This issue has been resolved in version @aws-northstar/ui-v1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants