fix(FormRenderer-Wizard): Fix an issue where validation can be skipped in certain scenarios. Close #991 #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in certain scenario
jessieweiyi
changed the title
jessieweiyi
changed the title
cogwirrel
approved these changes
Oct 30, 2023
|
🎉 This PR is included in version @aws-northstar/ui-v1.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#991
Description of changes:
This PR is to fix an issue where validation can be skipped in certain scenarios, for instance, the scenarios specified in the issue #991 by using a maximum step index parameter. If the active step index is less than the maximum step index (For the scenario that the user has visited a page after the current page and navigated back), the validation will be triggered.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.