feat(InfiniteQueryTable): add infinite query table for paginated react query hooks #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogwirrel
force-pushed
the
feat/infinite-query-table
branch
from
1f70643
to
f83abcb
Compare
jessieweiyi
reviewed
Sep 20, 2023
packages/ui/package.json
Outdated
| @@ -96,6 +98,9 @@ | |||
| "@types/uuid": "^9.0.0", | |||
| "amazon-cognito-identity-js": "^6.2.0", | |||
| "cross-fetch": "^3.1.6", | |||
| "lodash.chunk": "^4.2.0", | |||
There was a problem hiding this comment.
All lodash.* should be added to the dependencies (given that we might use it other occasions). Otherwise, consumers will not install them
|
|
||
| /** | ||
| * Extends the Cloudscape Table component with pagination options for @tanstack/react-query infinite query hooks. | ||
| * Compatible with generated hooks for paginated operations from AWS PDK Type Safe API. |
There was a problem hiding this comment.
Better to provide an URL from PDK doc, something like,
<a href='http://example.com' target="_blank" rel="noreferrer noopener">
…t query hooks Users of PDK's Type Safe API can make use of react query hooks generated from their API model. "Infinite query" hooks are generated for paginated operations. This change adds a table component which accepts the result of such a hook, and manages pagination by interacting with the hook, simplifying the effort required to build paginated tables when using Type Safe API and Northstar in tandem.
cogwirrel
force-pushed
the
feat/infinite-query-table
branch
from
f83abcb
to
9a7cfac
Compare
jessieweiyi
approved these changes
Sep 21, 2023
|
🎉 This PR is included in version @aws-northstar/ui-v1.1.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of PDK's Type Safe API can make use of react query hooks generated from their API model. "Infinite query" hooks are generated for paginated operations.
This change adds a table component which accepts the result of such a hook, and manages pagination by interacting with the hook, simplifying the effort required to build paginated tables when using Type Safe API and Northstar in tandem.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.