Fixed parsing issue when using ec2_iam_role option

[stemors]

Fixed issue with parsing error when trying to use a custom IAM role with the ec2_iam_role option:

"Unexpected error of type ValueError: too many values to unpack (expected 2)"

The code is looking for two values for this option, but there should only be one (the name of the IAM role). This change has been tested in my environment, and has resolved my issue.

Please See Git Pull Request Instructions

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[enrico-usai]

Hi @stemors , thank you for your effort.
Did you have the issue with the develop branch or with the released version?

I'm asking this because the issue should be already solved with: #1246

See source problem: #1241

[stemors]

My issue is with the released version 2.4.1 I looked, but had missed that bug fix you mentioned. That said, unless I'm missing something the code is still wrong, and should really be fixed? The fix in your link relates to the sanity checking.

The bug fix in this PR allows the code to work without having to turn off the sanity check. It's the root cause of the bug if you like.

[enrico-usai]

Hi @stemors ,
with your patch you're removing the sanity check validation for the EC2IAMRoleName resource but we actually need to validate it.

The real issue was in the sanity check code.
We fixed it with the # 1246, it will be available in the next release of ParallelCluster.

With that patch it is not more necessary to turn off the sanity check.

Thank you for your contribute.

[stemors]

Right, had a look again and I follow. So my change has disabled the sanity checking for a custom IAM role. Whereas the bug was actually in the sanity check of the custom role in config_sanity.py.

My mistake, thanks for the clarification, you can close this.

Steve