[BUG] Only one PDKPipeline can be created per account/region

[cogwirrel]

Describe the bug

See: #235

The exportName for the CodeRepositoryGRCUrl is hardcoded and so conflicts with a second deployment of PDKPipeline.

Expected Behavior

Able to deploy multiple PDKPipeline constructs in the same account/region

Current Behavior

Export with name CodeRepositoryGRCUrl is already exported by stack PipelineStack. Rollback requested by user.

Reproduction Steps

Deploy more than one PDKPipeline, either in the same app or as separate apps.

Possible Solution

Include props.repositoryName in the export name since this is already a unique name.

Additional Information/Context

No response

PDK version used

0.12.4

What languages are you seeing this issue on?

Typescript, Java, Python

Environment details (OS name and version, etc.)

OSX

[JeremyJonas]

@cogwirrel Agree that props.repositoryName prefix seems like a good solution, and creates a deterministic export name. Are there other exports we should consider prefixing while we are in there? Since all exports must be unique, best to always prefix to don't block other stacks

[cogwirrel]

Just had a quick look and yes, we should also prefix SonarqubeSecretArn https://github.com/aws/aws-prototyping-sdk/blob/5a2afcb075b20ca2980dc74d81e271adb38d52ec/packages/pipeline/src/code_scanner/sonar-code-scanner.ts#L227-L230

For this one we'll have to make sure our internal tool points to the new export name as we automate writing the sonar qube token to that secret :)

[github-actions]

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

[jstrunk]

Why is this even an export and not simply an output? I can't find anything that imports the value. I searched all of GitHub for CodeRepositoryGRCUrl, and the only results are the export and test snapshots.

If we make this a simple output, it will solve this problem.

[jstrunk]

I see examples of SonarqubeSecretArn getting imported but only in the aws-sample that was based on, so there's still a question of whether that needs to be exported.

How are developers using these values?

[cogwirrel]

The sonar qube secret export is used by our internal tool for bootstrapping new prototyping projects :) I'll send you a link!

As far as I know the code repo url is exported just so it's printed after a CDK deploy, so that users know what to put in the git remote add command :)