Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (cannot create new monorepo-py) #643

Closed
janrichter-fsq opened this issue Nov 8, 2023 · 1 comment · Fixed by #645
Closed

[BUG] (cannot create new monorepo-py) #643

janrichter-fsq opened this issue Nov 8, 2023 · 1 comment · Fixed by #645
Labels
bug Something isn't working

Comments

@janrichter-fsq
Copy link

Describe the bug

When creating a new monorepo in Python via command pdk new monorepo-py the installation fails.

Expected Behavior

Installation finishes successfully with new Python monorepo created.

Current Behavior

When installing Poetry dependencies, the process fails with:

Resolving dependencies... (1.0s)

Because pdk-python1 depends on @aws/pdk (*) which doesn't match any versions, version solving failed.
/Users/falnyr/projects/pdk-python1/node_modules/projen/lib/task-runtime.js:155
                    throw new Error(`Task "${this.fullname}" failed when executing "${command}" (cwd: ${(0, path_1.resolve)(cwd ?? this.workdir)})`);
                    ^

Error: Task "install" failed when executing "poetry update" (cwd: /Users/falnyr/projects/pdk-python1)

Reproduction Steps

Run pdk new monorepo-py in an empty folder.

Possible Solution

Current workaround is to remove dev_deps=["@aws/pdk"] dev dependency from .projenrc.py and run pdk again.

Additional Information/Context

Poetry (version 1.7.0)
Python 3.11.5

PDK version used

0.22.13

What languages are you seeing this issue on?

Python

Environment details (OS name and version, etc.)

MacOS Sonoma 14.1.1

@janrichter-fsq janrichter-fsq added the bug Something isn't working label Nov 8, 2023
@cogwirrel
Copy link
Member

Related projen bug: projen/projen#2475

Until the above is addressed I think we could work around it by having the MonorepoPyProject remove any dep called @aws/pdk

cogwirrel added a commit that referenced this issue Nov 10, 2023
…on monorepos

The projen new command adds a dependency on @aws/pdk when creating a new python monorepo, which
causes the initial install to fail as @aws/pdk is not the correct name for the module in pypi. The
workaround is for users to remove this dependency, but we can remove it within the monorepo for a
smoother initial bootstrap experience for python.

Fixes #643
cogwirrel added a commit that referenced this issue Nov 10, 2023
…on monorepos (#645)

The projen new command adds a dependency on @aws/pdk when creating a new python monorepo, which
causes the initial install to fail as @aws/pdk is not the correct name for the module in pypi. The
workaround is for users to remove this dependency, but we can remove it within the monorepo for a
smoother initial bootstrap experience for python.

Fixes #643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants