Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (cdk-graph-plugin-threat-composer) Generated architecture image too large for threat composer #721

Closed
cogwirrel opened this issue Mar 13, 2024 · 2 comments · Fixed by #728
Labels
bug Something isn't working needs-triage

Comments

@cogwirrel
Copy link
Member

Describe the bug

After adding some infrastructure, the embedded png image can be too large to import to threat composer.

Expected Behavior

Able to import a generated threat model into threat composer.

Current Behavior

Screenshot 2024-03-14 at 9 23 51 am

Reproduction Steps

Add a few components, import the generated threat-model.tc.json file into threat composer.

Possible Solution

Add support for svg images in threat composer as they will likely be much smaller. Consider also increasing the size limit.

Additional Information/Context

No response

PDK version used

0.23.13

What languages are you seeing this issue on?

Typescript, Java, Python

Environment details (OS name and version, etc.)

OSX

@cogwirrel cogwirrel added bug Something isn't working needs-triage labels Mar 13, 2024
@agdimech
Copy link
Contributor

Is this a bug in PDK or Threat composer?

@cogwirrel
Copy link
Member Author

Kind of both, I've raised one for threat composer here: awslabs/threat-composer#100

I think we should keep this open so we remember to switch to svg output.

cogwirrel added a commit that referenced this issue Mar 19, 2024
…id size limit

Embed the svg diagram into the generated threat model instead of the png as it is much smaller, and
does not exceed threat composer's 1MB image size limit.

Fixes #721
agdimech added a commit that referenced this issue Mar 19, 2024
…id size limit (#728)

Embed the svg diagram into the generated threat model instead of the png as it is much smaller, and
does not exceed threat composer's 1MB image size limit.

Fixes #721

Co-authored-by: Adrian Dimech <51220968+agdimech@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants