Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] licensed: false setting does not work as expected. #770

Closed
mtahir-cloudkitect opened this issue Apr 19, 2024 · 1 comment
Closed
Labels
bug Something isn't working needs-triage

Comments

@mtahir-cloudkitect
Copy link

Describe the bug

In a projen project when the following flag is used
licensed: false
then the package.json file is updated as
"license": "UNLICENSED"
and the default LICENSE file in the directory is removed.

However, PDK based project does not remove the LICENSE file from the project.

Expected Behavior

Using the flag should have the following impact
the package.json file is updated as
"license": "UNLICENSED"
and the default LICENSE file in the directory is removed.

Current Behavior

The default LICENSE file in the directory is removed.

Reproduction Steps

Create a PDK project
use the flag
licensed: false

synth the project by running pdk command.

Possible Solution

Don't use PDK, use Projen.

Additional Information/Context

No response

PDK version used

0.23.33

What languages are you seeing this issue on?

Typescript

Environment details (OS name and version, etc.)

Mac

@mtahir-cloudkitect mtahir-cloudkitect added bug Something isn't working needs-triage labels Apr 19, 2024
@agdimech
Copy link
Contributor

agdimech commented Apr 19, 2024

Hi @mtahir-cloudkitect,

We recently introduced a capability in PDK to disable licenses from being generated for all subprojects (by default they all get an Apache-2.0 license).

On the monorepo, if you add this it should solve your issue: licenseOptions: {disableDefaultLicenses: true}.

Here is the original PR that adds default licenses if interested: ab8e648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants