Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monorepo): support disableDefaultLicenses property #737

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

agdimech
Copy link
Contributor

Support disableDefaultLicenses property on the Monorepo to prevent licenses from being generated for all projects by default.

Fixes #736

@agdimech agdimech merged commit 8662693 into mainline Mar 28, 2024
3 checks passed
@agdimech agdimech deleted the fix/736 branch March 28, 2024 01:39
@nkhine-shieldpay
Copy link

Hi @agdimech
I have updated PDK to v0.23.30 and it seems the licences are still being created, here is my .projenrc.ts

const monorepo = new MonorepoTsProject({
  ...baseOptions,
  deps: ["@aws/pdk@0.23.30", "cdk-nag", "yaml", "zod@^3.22.4"],
  devDeps: ["@aws/pdk@0.23.30",],
  name: "pdk",
  packageManager: javascript.NodePackageManager.PNPM,
  projenrcTs: true,
  gitignore: [
    "!**/cdk.out/cdkgraph/diagram.png",
    "!**/cdk.out/cdkgrapgh/threat-model.tc.json",
    "!**/config.yml",
    "!bin/*.ts",
    "!lib/*.ts",
    "**/__snapshots__",
    "**/*.drawio.bkp",
    "**/cdk.out",
    "**/data",
    "**/dist",
    "steampipe/**/*.csv",
    "steampipe/**/*.txt",
  ],
  vscode: true,
  licensed: false,
  prettier: true,
  prettierOptions: {
    settings: {
      trailingComma: TrailingComma.ALL,
      singleQuote: false,
      printWidth: 120,
      semi: false,
    },
  },
});

git diff, yields, after running pdk at the root of my monorepo:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	projects/backup/LICENSE
	projects/github-runners/LICENSE
	projects/monitoring/LICENSE
	projects/pipeline/LICENSE

@agdimech
Copy link
Contributor Author

HI @nkhine-shieldpay - you need to use the licenseOptions: {disableDefaultLicenses: true} on the monorepo to prevent default licenses from being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Projects which set licensed to false emitting Apache 2.0
3 participants