Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for RuleActionOverrides for WAF using TypeSafeApi constructs #803

Open
2 tasks
dbryson opened this issue Jun 28, 2024 · 0 comments
Open
2 tasks
Labels
feature-request New feature or request needs-triage

Comments

@dbryson
Copy link

dbryson commented Jun 28, 2024

Describe the feature

Rule Action Overrides allow customizing WAF rules. It seems this support is missing from PDK:

Here is a link to Rule Action Overrides: https://docs.aws.amazon.com/waf/latest/APIReference/API_RuleActionOverride.html

Use Case

The current configuration lets me specify which WAF rule I wish to use:

Api(self, id, web_acl_options=TypeSafeApiWebAclOptions( cidr_allow_list=CidrAllowList( cidr_type="IPV4", cidr_ranges=["1.2.3.4/5"] ), managed_rules=[ManagedRule(vendor="AWS", name="AWSManagedRulesSQLiRuleSet")] ), ... )

But it doesn't provide the ability to customize the managed rule, despite the documentation indicating it supports these fields:

`import aws.pdk.type_safe_api

aws.pdk.type_safe_api.ManagedRule(
name: str,
excluded_rules: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, ExcludedRuleProperty]]] = None,
managed_rule_group_configs: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, ManagedRuleGroupConfigProperty]]] = None,
rule_action_overrides: typing.Union[IResolvable, typing.List[typing.Union[IResolvable, RuleActionOverrideProperty]]] = None,
scope_down_statement: typing.Union[IResolvable, StatementProperty] = None,
version: str = None,
vendor: str = None,
vendor_name: str = None
)`

Proposed Solution

Add support for the additional arguments.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

PDK version used

0.23.43

What languages will this feature affect?

Python

Environment details (OS name and version, etc.)

MacOS, Sonoma 14.3

@dbryson dbryson added feature-request New feature or request needs-triage labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant