refactor: support pnpm #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8663752. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
This PR is dependent on aws/jsii#4021 |
cogwirrel
reviewed
Mar 22, 2023
JeremyJonas
reviewed
Mar 24, 2023
JeremyJonas
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PNPM support to the PDK which results in huge performance gains.
In addition to performance gains, due to the nature of how PNPM sets up node_modules there is now no longer a need to hoist anything as everything gets symlinked from child packages. This solves the #282 .
NXMonorepo has also been updated to add a gitignore for
.nx/cachewhich solves #308 .Sharp prebuild is also fixed as previously we were not including the vendor and build folders when bundling cdk-graph-plugin.
NOTE: I have added a jsii-pacmak hack for the time being until aws/jsii#4030 is merged in order to prevent the build from breaking. Once that PR is merged and published, I will remove this workaround ASAP.
Fixes: #308, #282