SAM CLI Rust template for helloworld and S3 (using aws-sdk-rust) #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still in draft, moved it to ready for review only to see how many tests break (quite a few surely will), but I just realised that CI/CD is CodeBuild (buildspec.yml) so this will not get tested (by AWS) until merged? How shall I test it locally (with pytest)? I don't see any pointer(s) in the readme :-S At least I made sure that the Rust bits compile and |
|
Nevermind, the AWS Rust team is doing a great job with |
mndeveci
added a commit
to mndeveci/aws-sam-cli-app-templates
that referenced
this pull request
May 18, 2023
* Onboarded ruby3.2 * Update manifest-v2.json Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> * Migrate Ruby3.2 to Github Actions. * Update manifest-v2.json Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> * Add Ruby3.2 hello-img to manifest-v2.json. * Do not test lint for Ruby3.2. * Update README.md for Ruby3.2 hello-img cookiecutter project. * Remove buildspecs folder as it is no longer used. * Update commands in README.md for cookiecutter projects. * Update paths in Ruby3.2 unit tests. * move linting skip to build & invoke tests * Move skip linting to build & invoke tests * all tests should have skip lint until runtime is GA * update test assertion --------- Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Sean O Brien <sean.obrien.2016@mumail.ie> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Sean O Brien <briensea@amazon.com>
moelasmar
added a commit
that referenced
this pull request
Jun 1, 2023
* feat: add ruby3.2 to SAM (#129) * Onboarded ruby3.2 * Update manifest-v2.json Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> * Migrate Ruby3.2 to Github Actions. * Update manifest-v2.json Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> * Add Ruby3.2 hello-img to manifest-v2.json. * Do not test lint for Ruby3.2. * Update README.md for Ruby3.2 hello-img cookiecutter project. * Remove buildspecs folder as it is no longer used. * Update commands in README.md for cookiecutter projects. * Update paths in Ruby3.2 unit tests. * move linting skip to build & invoke tests * Move skip linting to build & invoke tests * all tests should have skip lint until runtime is GA * update test assertion --------- Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Sean O Brien <sean.obrien.2016@mumail.ie> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Sean O Brien <briensea@amazon.com> * bump pytest version * bump pytest version to 7.3 * bump pytest and pytest-xdist version * enable parallel test execution for dotnet test cases * bump pytest plugins versions, and disable dotnet integration testing parallel execution --------- Co-authored-by: trivenay <trivenay@amazon.com> Co-authored-by: Sean O Brien <sean.obrien.2016@mumail.ie> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Sean O Brien <briensea@amazon.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com> Co-authored-by: Mohamed ElAsmar <melasmar@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will eventually fix issue #54, WIP.
This is hopefully the first draft to walk towards a solution for the following long-standing Rust SAM-CLI UX issues on AWS SAM, championed by @softprops:
aws/aws-lambda-builders#174
And hopefully address my own Apple Silicon ring cross-compiling and its related ongoing S3-locally-backed
sam local start-apiissues.A working example can be found in https://github.com/umccr/s3-rust-noodles-bam.
This PR is a work in progress prompted by @jfuss helping addressing the aforementioned S3 SAM local issue, so that AWS has a simple SAM-CLI Rust template to iterate on top of.