feat(layers): remove compression of docker context (#862)

aws · Jan 18, 2019 · 4259a52 · 4259a52
1 parent 9fce3b4
commit 4259a52
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/samcli/lib/utils/tar.py b/samcli/lib/utils/tar.py
@@ -23,7 +23,7 @@ def create_tarball(tar_paths):
     """
     tarballfile = TemporaryFile()
 
-    with tarfile.open(fileobj=tarballfile, mode='w:gz') as archive:
+    with tarfile.open(fileobj=tarballfile, mode='w') as archive:
         for path_on_system, path_in_tarball in tar_paths.items():
             archive.add(path_on_system, arcname=path_in_tarball)
 

diff --git a/samcli/local/docker/lambda_image.py b/samcli/local/docker/lambda_image.py
@@ -182,7 +182,6 @@ def _build_image(self, base_image, docker_tag, layers):
                     self.docker_client.images.build(fileobj=tarballfile,
                                                     custom_context=True,
                                                     rm=True,
-                                                    encoding='gzip',
                                                     tag=docker_tag,
                                                     pull=not self.skip_pull_image)
                 except (docker.errors.BuildError, docker.errors.APIError):

diff --git a/tests/unit/lib/utils/test_tar.py b/tests/unit/lib/utils/test_tar.py
@@ -25,4 +25,4 @@ def test_generating_tarball(self, temporary_file_patch, tarfile_open_patch):
         temp_file_mock.flush.assert_called_once()
         temp_file_mock.seek.assert_called_once_with(0)
         temp_file_mock.close.assert_called_once()
-        tarfile_open_patch.assert_called_once_with(fileobj=temp_file_mock, mode='w:gz')
+        tarfile_open_patch.assert_called_once_with(fileobj=temp_file_mock, mode='w')
diff --git a/tests/unit/local/docker/test_lambda_image.py b/tests/unit/local/docker/test_lambda_image.py
@@ -171,8 +171,7 @@ def test_build_image(self, generate_dockerfile_patch, path_patch, uuid_patch, cr
                                                                 rm=True,
                                                                 tag="docker_tag",
                                                                 pull=False,
-                                                                custom_context=True,
-                                                                encoding='gzip')
+                                                                custom_context=True)
 
         docker_full_path_mock.unlink.assert_called_once()
 
@@ -218,8 +217,7 @@ def test_build_image_fails_with_BuildError(self,
                                                                 rm=True,
                                                                 tag="docker_tag",
                                                                 pull=False,
-                                                                custom_context=True,
-                                                                encoding='gzip')
+                                                                custom_context=True)
 
         docker_full_path_mock.unlink.assert_not_called()
 
@@ -264,6 +262,5 @@ def test_build_image_fails_with_ApiError(self,
                                                                 rm=True,
                                                                 tag="docker_tag",
                                                                 pull=False,
-                                                                custom_context=True,
-                                                                encoding='gzip')
+                                                                custom_context=True)
         docker_full_path_mock.unlink.assert_called_once()