fix: Making integration tests work on Windows (#494)

aws · Jun 18, 2018 · dd3c556 · dd3c556
1 parent f88bbd3
commit dd3c556
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -283,7 +283,7 @@ instance/
 docs/_build/
 
 # PyBuilder
-target/
+/target/
 
 # Jupyter Notebook
 .ipynb_checkpoints

diff --git a/tests/integration/local/invoke/runtimes/test_with_runtime_zips.py b/tests/integration/local/invoke/runtimes/test_with_runtime_zips.py
@@ -13,14 +13,16 @@ def setUp(self):
 
         self.template_path = os.path.join(self.test_data_path, "invoke", "runtimes", "template.yaml")
 
-        self.events_file = tempfile.NamedTemporaryFile()
-        self.events_file.write('"yolo"')  # Just empty event
-        self.events_file.flush()
+        # Don't delete on close. Need the file to be present for tests to run.
+        events_file = tempfile.NamedTemporaryFile(delete=False)
+        events_file.write(b'"yolo"')  # Just empty event
+        events_file.flush()
+        events_file.close()
 
-        self.events_file_path = self.events_file.name
+        self.events_file_path = events_file.name
 
     def tearDown(self):
-        self.events_file.close()
+        os.remove(self.events_file_path)
 
     @parameterized.expand([
         param("Go1xFunction"),

diff --git a/tests/integration/testdata/invoke/runtimes/java8/target/HelloWorld-1.0.jar b/tests/integration/testdata/invoke/runtimes/java8/target/HelloWorld-1.0.jar