Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does sam support sym linked node_modules? #1446

Closed
ktersius opened this issue Oct 6, 2019 · 3 comments
Closed

Does sam support sym linked node_modules? #1446

ktersius opened this issue Oct 6, 2019 · 3 comments
Labels
area/build sam build command area/local/start-api sam local start-api command type/question

Comments

@ktersius
Copy link

ktersius commented Oct 6, 2019

In order to speed up our build process we switched to symlinking the /dist/node_modules folder to our ./node_modules folder instead of copying it over on builds.

Unfortunately this seems to break sam local start-api as on the very first require it cannot find the module.

Is there some way to get this to work or just not supported?

@ktersius ktersius changed the title Symlinked node_modules breaks sam local start-api Does sam support sym linked node_modules? Oct 6, 2019
@sriram-mv
Copy link
Contributor

For symlinks to work inside containers, I believe they need to be absolute paths, and both directories need to be mounted within the container. Need to dig deeper on this particular issue.

@sriram-mv
Copy link
Contributor

Going to close this issue in favor of esbuild solutions for faster builds along with cached and parallel builds. Please re-open this issue if it's still something that we need to target.

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command area/local/start-api sam local start-api command type/question
Projects
None yet
Development

No branches or pull requests

2 participants