New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-string response body breaks SAM CLI #38

Closed

sanathkr opened this issue Aug 14, 2017 · 0 comments

Contributor

sanathkr commented Aug 14, 2017

https://github.com/teknogeek0/aws-serverless-samfarm-api/blob/master/index.js#L25 returns a integer in body property of Proxy response. SAM CLI expects body to be a string when JSON unmarshalling - start.go#L187.

These are valid JSON types: http://json-schema.org/latest/json-schema-core.html#rfc.section.4.2

The text was updated successfully, but these errors were encountered:

PaulMaddox mentioned this issue

If the 'body' returned by a Lambda function is a number, don't choke. #39

Merged

sanathkr closed this as completed in #39

sanathkr pushed a commit that referenced this issue


          If the 'body' returned by a Lambda function is a number, don't choke. (…

8c47aee

…#39)

This uses the json encoding package's json.Number type to transparently
work with both a number and/or a string. If it's a number, the json
encoding will convert it to a string.

See:
http://igorsobreira.com/2015/04/11/decoding-json-numbers-into-strings-in-go.html

Fixes #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment