Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples link in Readme broken #430

Closed
oharaandrew314 opened this issue May 23, 2018 · 3 comments
Closed

Examples link in Readme broken #430

oharaandrew314 opened this issue May 23, 2018 · 3 comments
Labels
area/docs type/documentation

Comments

@oharaandrew314
Copy link

oharaandrew314 commented May 23, 2018 •
edited
Loading

In the Examples Section of the Readme, there's a link to a samples folder, which is broken.

Where should we send users to instead?
@default50
Copy link

default50 commented May 24, 2018 •
edited
Loading

Just spotted the same. This is the commit that removed the samples/ dir, from 8th May:

9dcd0bc

And this is the PR: #383

@default50 default50 mentioned this issue May 24, 2018
Closed
@oharaandrew314 oharaandrew314 mentioned this issue May 29, 2018
Closed
@oharaandrew314
Copy link
Author

Good catch, I've created a PR to remove the broken link.

@jfuss jfuss mentioned this issue May 29, 2018
Merged
@sriram-mv
Copy link
Contributor

Closing this issue, as PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs type/documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@default50 @oharaandrew314 @sriram-mv @jfuss