Fix examples link in README #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvsood
reviewed
May 25, 2018
README.rst
Outdated
| README under the | ||
| `samples <https://github.com/awslabs/aws-sam-local/tree/master/samples>`__ | ||
| folder within this repo. | ||
| You can find sample code and SAM templates in this |
There was a problem hiding this comment.
Thanks for cleaning this up, @default50!
In "You can find sample code and SAM templates in this", please change this => the. The rest looks good to me.
|
Please make sure you are following our Contribution Guide. Closing this PR since someone else has already submitting a PR before this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #430
Description of changes: As per this comment on the PR #383 that triggered this issue, the right place for samples is under
examplesdirectory of serverless-application-model. Updated README file to reflect this and while at it fixed a typo and a link to a username.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.