Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-event: Add S3 Batch Operations Event #4521

Closed
arjunrawal4 opened this issue Dec 29, 2022 · 3 comments
Closed

generate-event: Add S3 Batch Operations Event #4521

arjunrawal4 opened this issue Dec 29, 2022 · 3 comments
Labels
stage/pr Has a PR ready for review stage/waiting-for-release Fix has been merged to develop and is waiting for a release type/feature Feature request

Comments

@arjunrawal4
Copy link
Contributor

Describe your idea/feature/enhancement

S3 Batch Operations is missing from sam local generate-event. It would be nice to have sample events for Batch Operations lambda invocations

Proposal

Add new event to SAM.

{
    "invocationSchemaVersion": "1.0",
    "invocationId": "YXNkbGZqYWRmaiBhc2RmdW9hZHNmZGpmaGFzbGtkaGZza2RmaAo",
    "job": {
        "id": "f3cc4f60-61f6-4a2b-8a21-d07600c373ce"
    },
    "tasks": [
        {
            "taskId": "dGFza2lkZ29lc2hlcmUK",
            "s3Key": "customerImage1.jpg",
            "s3VersionId": "1",
            "s3BucketArn": "arn:aws:s3:us-east-1:0123456788:awsexamplebucket1"
        }
    ]
}

Additional Details

https://docs.aws.amazon.com/lambda/latest/dg/services-s3-batch.html
https://docs.aws.amazon.com/AmazonS3/latest/userguide/batch-ops-invoke-lambda.html
https://github.com/awsdocs/amazon-s3-developer-guide/blob/master/doc_source/batch-ops-invoke-lambda.md

@arjunrawal4 arjunrawal4 added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Dec 29, 2022
arjunrawal4 added a commit to arjunrawal4/aws-sam-cli that referenced this issue Dec 29, 2022
@moelasmar
Copy link
Contributor

Thanks @arjunrawal4 for raising this feature. I checked your PR and looks good to me, I will ask the team to provide another approval to merge it.

@moelasmar moelasmar added stage/pr Has a PR ready for review and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Dec 30, 2022
hawflau added a commit that referenced this issue Jan 5, 2023
* feat: Add support for S3 Batch Operations event (#4521)

* Use proper s3 bucket arn syntax

Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
@hawflau hawflau added the stage/waiting-for-release Fix has been merged to develop and is waiting for a release label Jan 6, 2023
@sriram-mv
Copy link
Contributor

Closing as part of 1.69.0 release.

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/pr Has a PR ready for review stage/waiting-for-release Fix has been merged to develop and is waiting for a release type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants